Revert "Notify systemd only once db and server containers are healthy" (bsc#1270399, bsc#1270398)#820
Merged
Merged
Conversation
aaannz
changed the title
mcalmer
approved these changes
Jul 7, 2026
mcalmer
reviewed
Jul 7, 2026
Comment on lines
+14
to
+15
| const pgsqlServiceTemplate = `# uyuni-db-server.service, generated by mgradm | ||
| # Use an uyuni-db-server.service.d/local.conf file to override |
Contributor
There was a problem hiding this comment.
Is changing this comment back correct? I do not see any change in the service name
Contributor
Author
There was a problem hiding this comment.
I reverted the whole commit using git revert. That was the original state.
Contributor
There was a problem hiding this comment.
Yes, but is the comment correct or wrong?
If it is wrong, we may want to add a commit to at least fix this?
Contributor
Author
There was a problem hiding this comment.
Added a commit fixing this service name.
|
mcalmer
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change?
This reverts commit 20f1925.
podman 4.9.5 causes panics with sdnotify. We will need podman 5.2.0 at minimum which is not present on SP7.
Codespace
Check if you already have a running container clicking on
Test coverage
No tests: add explanation
DONE
Links
Issue(s): https://bugzilla.suse.com/show_bug.cgi?id=1270398 https://bugzilla.suse.com/show_bug.cgi?id=1270399
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Before you merge
Check How to branch and merge properly!